fix: prevent file path corruption in file tools #9299
+237
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eTool - Remove incorrect removeClosingTag calls from execute methods - removeClosingTag should only be used in handlePartial for streaming - Fixes issue where paths ending with "str" were corrupted - Add comprehensive tests for path handling Fixes #9298
dosubot
bot
added
size:L
Contributor
Author
Review complete. No issues found. The latest commit properly fixes the test failures by using Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
|
@roomote appear that we get 2 fail, you have to review the currentpr and made more robust solution |
Contributor
Author
Fixed the Windows test failures by making path expectations platform-independent. |
This was referenced Nov 16, 2025
bozoweed
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9298. Feedback and guidance are welcome.
Problem
File paths containing or ending with "str" were being corrupted when using file tools (WriteToFileTool and GenerateImageTool). For example, a path like
/root/oxyde_strat/stratoxyde-v2/src/services/storage/saveStates.tswould be incorrectly processed, creating a file named "str" in the working directory.Root Cause
The
removeClosingTagfunction was being incorrectly called in theexecutemethods of these tools. This function is meant for cleaning up partial XML tags during streaming (inhandlePartialmethods), but was being misused on actual file paths.Solution
removeClosingTagcalls fromexecutemethods in WriteToFileTool and GenerateImageToolremoveClosingTagremains available for its intended purpose inhandlePartialmethodsChanges
Testing
Important
Fixes file path corruption in
WriteToFileToolandGenerateImageToolby removing incorrectremoveClosingTagcalls and adds tests for verification.removeClosingTagcalls fromexecutemethods inWriteToFileToolandGenerateImageToolto prevent file path corruption.pathCorruption.spec.tsto test paths ending or containing "str" inWriteToFileToolandGenerateImageTool.removeClosingTagis retained forhandlePartialmethods only.This description was created by
for ca4a39d. You can customize this summary. It will automatically update as commits are pushed.